Fix Pagination #1198
Merged
Fix Pagination #1198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattr- this is ready for review :) |
| @@ -29,7 +29,7 @@ class Configuration < Hash | |||
| 'baseurl' => '/', | |||
| 'include' => ['.htaccess'], | |||
| 'exclude' => [], | |||
| 'paginate_path' => 'page:num', | |||
| 'paginate_path' => '/page:num', | |||
There was a problem hiding this comment.
I'm missing some context for this change. How is the added slash significant here?
There was a problem hiding this comment.
It's not significant as far as I know.
There was a problem hiding this comment.
I was just testing with both :)
|
@mattr- – Any further comments? I think I'd like to hold off on the URL Helper for a different PR. |
|
I'm cool with that. On Sat, Jun 22, 2013 at 10:08 AM, Parker Moore notifications@github.com
|
👍
parkr
added a commit
that referenced
this pull request
Jun 23, 2013
This was referenced Jul 5, 2013
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New: Look for an index.html page starting in the
paginate_pathand searching upward (in the FS tree) until anindex.htmlis found.